test: ElasticSearchDocumentStore relying on Mixin tests#2995
Merged
davidsbatista merged 8 commits intomainfrom Mar 20, 2026
Merged
test: ElasticSearchDocumentStore relying on Mixin tests#2995davidsbatista merged 8 commits intomainfrom
ElasticSearchDocumentStore relying on Mixin tests#2995davidsbatista merged 8 commits intomainfrom
Conversation
ElasticSearchDocumentStore uses all the
ElasticSearchDocumentStore uses all the Mixin tests to ElasticSearchDocumentStore uses all the
Mixin tests to ElasticSearchDocumentStore uses all the ElasticSearchDocumentStore using more Mixin tests
ElasticSearchDocumentStore using more Mixin testsElasticSearchDocumentStore relying on Mixin tests
anakin87
approved these changes
Mar 20, 2026
Member
anakin87
left a comment
There was a problem hiding this comment.
Thank you.
Left a minor comment.
In addition, I am not sure that async tests use the fixture in conftest.py.
In any case, OK to close the async client if present.
Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
Contributor
Author
I was getting a warning about resources not being closed, they went away with that addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.