Skip to content

test: ElasticSearchDocumentStore relying on Mixin tests#2995

Merged
davidsbatista merged 8 commits intomainfrom
test/elasticsearch-use-mixin-tests
Mar 20, 2026
Merged

test: ElasticSearchDocumentStore relying on Mixin tests#2995
davidsbatista merged 8 commits intomainfrom
test/elasticsearch-use-mixin-tests

Conversation

@davidsbatista
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista commented Mar 20, 2026

Proposed Changes:

  • adding missing tests for ElasticSearch operations through Mixin
  • The conftest.py sync fixtures were being used by async integration tests; the fixture teardown only closes the sync client, _async_client was never closed, it's now fixed

How did you test it?

  • run all unit tests, integration tests and CI tests

Checklist

@github-actions github-actions Bot added integration:elasticsearch type:documentation Improvements or additions to documentation labels Mar 20, 2026
@davidsbatista davidsbatista changed the title initial import test: add Mixin tests to ElasticSearchDocumentStore uses all the Mar 20, 2026
@davidsbatista davidsbatista changed the title test: add Mixin tests to ElasticSearchDocumentStore uses all the test: add Mixin tests to ElasticSearchDocumentStore uses all the Mar 20, 2026
@davidsbatista davidsbatista changed the title test: add Mixin tests to ElasticSearchDocumentStore uses all the test: ElasticSearchDocumentStore using more Mixin tests Mar 20, 2026
@davidsbatista davidsbatista changed the title test: ElasticSearchDocumentStore using more Mixin tests test: ElasticSearchDocumentStore relying on Mixin tests Mar 20, 2026
@davidsbatista davidsbatista marked this pull request as ready for review March 20, 2026 15:17
@davidsbatista davidsbatista requested a review from a team as a code owner March 20, 2026 15:17
@davidsbatista davidsbatista requested review from anakin87 and removed request for a team March 20, 2026 15:17
Copy link
Copy Markdown
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Left a minor comment.

In addition, I am not sure that async tests use the fixture in conftest.py.
In any case, OK to close the async client if present.

Comment thread integrations/elasticsearch/tests/conftest.py Outdated
Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
@davidsbatista
Copy link
Copy Markdown
Contributor Author

Thank you.

Left a minor comment.

In addition, I am not sure that async tests use the fixture in conftest.py. In any case, OK to close the async client if present.

I was getting a warning about resources not being closed, they went away with that addition

@davidsbatista davidsbatista merged commit 545492e into main Mar 20, 2026
9 checks passed
@davidsbatista davidsbatista deleted the test/elasticsearch-use-mixin-tests branch March 20, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:elasticsearch type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants