Skip to content

!test: QdrantDocumentStore use Mixin tests + updated signature get_metadata_fields_info(self) -> dict[str, dict[str, str]]:#3004

Merged
davidsbatista merged 7 commits intomainfrom
test/qdrant-use-mixin-tests
Mar 23, 2026
Merged

!test: QdrantDocumentStore use Mixin tests + updated signature get_metadata_fields_info(self) -> dict[str, dict[str, str]]:#3004
davidsbatista merged 7 commits intomainfrom
test/qdrant-use-mixin-tests

Conversation

@davidsbatista
Copy link
Copy Markdown
Contributor

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@github-actions github-actions Bot added integration:qdrant type:documentation Improvements or additions to documentation labels Mar 20, 2026
@davidsbatista davidsbatista changed the title Test/qdrant use mixin tests Test: QdrantDocumentStore use Mixin tests Mar 20, 2026
@davidsbatista davidsbatista marked this pull request as ready for review March 23, 2026 14:21
@davidsbatista davidsbatista requested a review from a team as a code owner March 23, 2026 14:21
@davidsbatista davidsbatista requested review from anakin87 and removed request for a team March 23, 2026 14:21
@davidsbatista
Copy link
Copy Markdown
Contributor Author

Also needs a new release since this was updated:

 get_metadata_fields_info(self) -> dict[str, dict[str, str]]:

for consistency and passing the Mixin tests

Copy link
Copy Markdown
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this involves a breaking change, I'd also change the title of the PR to describe what changed. The title is used to populate the CHANGELOG.md file.

@davidsbatista
Copy link
Copy Markdown
Contributor Author

Since this involves a breaking change, I'd also change the title of the PR to describe what changed. The title is used to populate the CHANGELOG.md file.

good catch! thanks 👍🏽

@davidsbatista davidsbatista changed the title Test: QdrantDocumentStore use Mixin tests !test: QdrantDocumentStore use Mixin tests + updated signature get_metadata_fields_info(self) -> dict[str, dict[str, str]]: Mar 23, 2026
@davidsbatista davidsbatista merged commit a019037 into main Mar 23, 2026
13 checks passed
@davidsbatista davidsbatista deleted the test/qdrant-use-mixin-tests branch March 23, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:qdrant type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants