chore: enforce ruff docstring rules in integrations 11-20 (deepeval, elasticsearch, faiss, fastembed, firecrawl, github, google_genai, hanlp, jina, kreuzberg)#3009
Merged
julian-risch merged 1 commit intomainfrom Mar 23, 2026
Conversation
…19) in integrations 11-20 Adds D102, D103, D205, D209, D213, D417, D419 ruff rules to pyproject.toml for: deepeval, elasticsearch, faiss, fastembed, firecrawl, github, google_genai, hanlp, jina, kreuzberg. Fixes all resulting docstring violations. Part of #2947 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
integration:elasticsearch
integration:jina
integration:deepeval
integration:fastembed
integration:github
integration:google-genai
integration:hanlp
integration:firecrawl
integration:faiss
integration:kreuzberg
type:documentation
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Part 2/5 of #2947
Proposed Changes:
pyproject.tomlfor 10 integrations: deepeval, elasticsearch, faiss, fastembed, firecrawl, github, google_genai, hanlp, jina, kreuzbergruff --fix; D205 violations fixed manuallyHow did you test it?
Ran for each integration:
hatch run fmt-check— all passhatch run test:types— all passhatch run test:unit— all passNotes for the reviewer
This is batch 2 of the docstring rules enforcement. Batch 1 (aimlapi through cometapi) was #3008.
I skipped two archived google integrations.
As mentioned in #3008, I thought about adding D107, which is not mentioned in the issue. D107 checks that init method definitions have docstrings. I could open one separate PR that adds D107 to all integrations and one PR to add it to Haystack if we agree its beneficial. For consistency it makes sense but there is not much value added but the
__init__docstrings so it's not of importance.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.