test: FaissDocumentStore use Mixin tests#3024
Merged
davidsbatista merged 6 commits intomainfrom Mar 23, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
integration:faiss
type:documentation
davidsbatista
changed the title
FaissDocumentStore use Mixin tests
davidsbatista
requested review from
anakin87 and
bogdankostic
and removed request for
a team and
bogdankostic
anakin87
approved these changes
Mar 23, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Looks good.
Added a comment about the breaking change.
| return list(values) | ||
|
|
||
| def count_unique_metadata_by_filter(self, filters: dict[str, Any], fields: list[str]) -> dict[str, int]: | ||
| def count_unique_metadata_by_filter(self, filters: dict[str, Any], metadata_fields: list[str]) -> dict[str, int]: |
Member
There was a problem hiding this comment.
this is a breaking change.
I'm ok with it (for consistency), but let's make sure to release a new major version (2.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
FaissDocumentStoreuse Mixin testsHow did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.