Skip to content

fix: jina base url pass as params#3032

Merged
sjrl merged 8 commits intodeepset-ai:mainfrom
srini047:jina-base-url-params
Mar 24, 2026
Merged

fix: jina base url pass as params#3032
sjrl merged 8 commits intodeepset-ai:mainfrom
srini047:jina-base-url-params

Conversation

@srini047
Copy link
Copy Markdown
Contributor

@srini047 srini047 commented Mar 23, 2026

Related Issues

Proposed Changes:

Currently JINA_API_URL which can be referred to as the base_url is hardcoded for every jina supported operation like ranker and embedding. We should allow this to be passed as a param where users can have control over.

How did you test it?

Run the existing tests and added serialization/deserialization tests for base_url

Checklist

@srini047 srini047 requested a review from a team as a code owner March 23, 2026 14:58
@srini047 srini047 requested review from davidsbatista and removed request for a team March 23, 2026 14:58
@github-actions github-actions Bot added integration:jina type:documentation Improvements or additions to documentation labels Mar 23, 2026
sjrl
sjrl reviewed Mar 24, 2026
View reviewed changes
Comment thread integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py Outdated
sjrl
sjrl reviewed Mar 24, 2026
View reviewed changes
Comment thread integrations/jina/src/haystack_integrations/components/embedders/jina/text_embedder.py Outdated
sjrl
sjrl reviewed Mar 24, 2026
View reviewed changes
Comment thread integrations/jina/src/haystack_integrations/components/rankers/jina/ranker.py Outdated
@sjrl sjrl requested review from sjrl and removed request for davidsbatista March 24, 2026 07:39
@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Mar 24, 2026

@davidsbatista I can take the review since I opened the original issue

@srini047
Copy link
Copy Markdown
Contributor Author

srini047 commented Mar 24, 2026

@sjrl Have made the changes changing base_url to kwargs to avoid breaking the exisitng pipeline.

sjrl
sjrl reviewed Mar 24, 2026
View reviewed changes
Comment thread integrations/jina/tests/test_document_embedder.py Outdated
sjrl
sjrl reviewed Mar 24, 2026
View reviewed changes
Comment thread integrations/jina/tests/test_ranker.py Outdated
sjrl
sjrl reviewed Mar 24, 2026
View reviewed changes
Comment thread integrations/jina/tests/test_text_embedder.py Outdated
@srini047 srini047 requested a review from sjrl March 24, 2026 13:22
sjrl
sjrl approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjrl sjrl merged commit dad7f72 into deepset-ai:main Mar 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrl sjrl sjrl approved these changes

Assignees

No one assigned

Labels

integration:jina type:documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make base url in Jina Embedders customizable

2 participants

@srini047 @sjrl