feat(weaviate): add tenant support in write_documents with tests (syn… by Akash504-ai · Pull Request #3056 · deepset-ai/haystack-core-integrations

Akash504-ai · 2026-03-26T09:30:58Z

Related Issues

fixes Weaviate: Consider Adding support for multi tenancy #472

Proposed Changes

Added tenant support to write_documents and write_documents_async
Updated internal batch write logic to pass tenant parameter correctly
Enables basic multi-tenancy support for Weaviate document store
Added tests for tenant support in:
- sync document store
- async document store

How did you test it?

Added integration tests for:
- test_write_documents_with_tenant
- test_write_documents_with_tenant_async
Verified no regression in default (non-tenant) behavior
Did not run full Weaviate integration locally, relying on CI for validation

Notes for the reviewer

Changes are minimal and focused on tenant support in write operations
Both sync and async flows are covered
Backward compatible (no tenant → existing behavior unchanged)

Checklist

I have read the contributors guidelines and code of conduct
I have updated the related issue
I added tests
I used a conventional commit message

CLAassistant · 2026-03-26T09:31:06Z

All committers have signed the CLA.

…c + async)

… write

… consistency

julian-risch

Hello @Akash504-ai Thank you for opening this pull request. I have a couple of smaller change requests, which I explain in more detail below. Please keep comments that are not related to tenant_support unchanged in this pull request. Other than that the code changes look quite good to me already.

julian-risch · 2026-04-02T14:07:42Z

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py


        :param filters: The filters to apply to select documents for deletion.
-            For filter syntax, see [Haystack metadata filtering](https://docs.haystack.deepset.ai/docs/metadata-filtering)
+            For filter syntax, see Haystack metadata filtering docs.


Let's keep this link

julian-risch · 2026-04-02T14:07:57Z

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

-        :param filters: The filters to apply to select documents for deletion.
-            For filter syntax, see [Haystack metadata filtering](https://docs.haystack.deepset.ai/docs/metadata-filtering)
-        :returns: The number of documents deleted.
+        :param filters: Filters to select documents for deletion.


Let's keep this link

julian-risch · 2026-04-02T14:08:19Z

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

-            For filter syntax, see [Haystack metadata filtering](https://docs.haystack.deepset.ai/docs/metadata-filtering)
-        :param meta: The metadata fields to update. These will be merged with existing metadata.
-        :returns: The number of documents updated.
+        :param filters: Filters to select documents for updating.


Let's keep this link

julian-risch · 2026-04-02T14:08:44Z

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

            raise ValueError(msg)

        try:
+            collection = self.collection  # ✅ FIX


Suggested change

collection = self.collection # ✅ FIX

collection = self.collection

julian-risch · 2026-04-02T14:09:04Z

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

                        vector = obj.vector

-                    self.collection.data.replace(
+                    collection.data.replace(  # ✅ FIX


Suggested change

collection.data.replace( # ✅ FIX

collection.data.replace(

julian-risch · 2026-04-02T14:11:10Z

integrations/weaviate/tests/test_document_store.py

 import base64
 import logging
 import os
+import platform


Suggested change

import platform

julian-risch · 2026-04-02T14:12:06Z

integrations/weaviate/tests/test_document_store.py

+        doc = Document(content="tenant test doc")
+
+        # Write with tenant
+        written = document_store.write_documents([doc], tenant="tenant1")


this test could check that _write get's called with the expected tenant parameter value.

julian-risch · 2026-04-02T14:12:52Z

integrations/weaviate/tests/test_document_store_async.py

+    async def test_write_documents_with_tenant_async(self, document_store):
+        doc = Document(content="tenant test doc")
+
+        written = await document_store.write_documents_async([doc], tenant="tenant1")


This test could check if _write_async get's called with the expected tenant parameter value.

julian-risch · 2026-04-02T14:13:46Z

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

-
-        Documents with the same id will be overwritten.
-        Raises in case of errors.


Please keep comments that are not related to tenant_support unchanged in this pull request.

julian-risch · 2026-04-02T14:13:58Z

integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py

-        # If the document already exists we get no status message back from Weaviate.
-        # So we assume that all Documents were written.


Please keep comments that are not related to tenant_support unchanged in this pull request.

…nt store tests

Akash504-ai · 2026-04-07T05:25:48Z

Thanks for the suggestion! Initially I implemented the test using _write_async mocking, but it was not aligned with the current implementation and caused CI failures.
I updated the test to validate the actual behavior instead. Let me know if you'd prefer keeping the internal call assertion happy to adjust accordingly.

Akash504-ai requested a review from a team as a code owner March 26, 2026 09:30

Akash504-ai requested review from julian-risch and removed request for a team March 26, 2026 09:31

github-actions bot added integration:weaviate type:documentation Improvements or additions to documentation labels Mar 26, 2026

Akash504-ai added 2 commits March 26, 2026 23:23

feat(weaviate): add tenant support in write_documents with tests (syn…

862a160

…c + async)

feat(weaviate): add tenant support in write_documents and async batch…

73e97f2

… write

Akash504-ai force-pushed the feat/weaviate-multitenancy branch from 1fe6aeb to 73e97f2 Compare March 26, 2026 17:53

Akash504-ai added 4 commits March 26, 2026 23:59

feat(weaviate): add tenant support for write operations and fix async…

2bc6722

… consistency

fix(weaviate): add missing docstrings for new methods

e3f55cf

fix: format weaviate tests (ruff auto-fix)

126d072

fix: format document_store with ruff

c938971

julian-risch requested changes Apr 2, 2026

View reviewed changes

Akash504-ai added 4 commits April 7, 2026 10:26

feat(weaviate): add multitenancy support and extend sync/async docume…

33da4b4

…nt store tests

Merge branch 'main' into feat/weaviate-multitenancy

b18d575

fix(weaviate): align async tenant test with implementation

5195d08

fix: remove unused patch import in async test

86365d7

	collection = self.collection # ✅ FIX
	collection = self.collection


		Documents with the same id will be overwritten.
		Raises in case of errors.

		# If the document already exists we get no status message back from Weaviate.
		# So we assume that all Documents were written.

Conversation

Akash504-ai commented Mar 26, 2026

Related Issues

Proposed Changes

How did you test it?

Notes for the reviewer

Checklist

Uh oh!

CLAassistant commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julian-risch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Akash504-ai commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CLAassistant commented Mar 26, 2026 •

edited

Loading