Skip to content

test: mark some tests as integration in Faiss and Qdrant#3076

Merged
anakin87 merged 4 commits into
mainfrom
missing-int-wfs
Apr 1, 2026
Merged

test: mark some tests as integration in Faiss and Qdrant#3076
anakin87 merged 4 commits into
mainfrom
missing-int-wfs

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 1, 2026

Related Issues

For some integrations, we don't have integration tests.

For Faiss and Qdrant, we have them, but they were not correctly marked.

Proposed Changes:

  • mark integration tests
  • add missing integration tests workflow: runs integration tests and save combined coverage

How did you test it?

CI

Notes for the reviewer

Despite the git diff, I just moved some tests around

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (qdrant)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/qdrant/src/haystack_integrations/components/retrievers/qdrant
  retriever.py
  integrations/qdrant/src/haystack_integrations/document_stores/qdrant
  converters.py
  document_store.py
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (ragas)

This PR does not seem to contain any modification to coverable code.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (faiss)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/faiss/src/haystack_integrations/components/retrievers/faiss
  embedding_retriever.py
  integrations/faiss/src/haystack_integrations/document_stores/faiss
  document_store.py
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 marked this pull request as ready for review April 1, 2026 10:39
@anakin87 anakin87 requested a review from a team as a code owner April 1, 2026 10:39
@anakin87 anakin87 requested review from bogdankostic and davidsbatista and removed request for a team April 1, 2026 10:39
@anakin87 anakin87 self-assigned this Apr 1, 2026
@davidsbatista
Copy link
Copy Markdown
Contributor

thanks - Qdrant had for long only unit tests as far as I remember

@anakin87 anakin87 merged commit 3c4ec18 into main Apr 1, 2026
26 checks passed
@anakin87 anakin87 deleted the missing-int-wfs branch April 1, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants