refactor(qdrant): use async DocumentStore mixin tests#3093
Open
SyedShahmeerAli12 wants to merge 3 commits intodeepset-ai:mainfrom
Open
refactor(qdrant): use async DocumentStore mixin tests#3093SyedShahmeerAli12 wants to merge 3 commits intodeepset-ai:mainfrom
SyedShahmeerAli12 wants to merge 3 commits intodeepset-ai:mainfrom
Conversation
github-actions
bot
added
integration:qdrant
type:documentation
anakin87
requested changes
Apr 2, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
👋
Could you please fix the conflict?
SyedShahmeerAli12
force-pushed
the
refactor/qdrant-async-mixin-tests
branch
from
09aa131 to
1028adb
Compare
| from haystack.document_stores.errors import DuplicateDocumentError | ||
| from haystack.document_stores.types import DuplicatePolicy | ||
| from haystack.testing.document_store import ( | ||
| CountDocumentsByFilterAsyncTest, |
Contributor
There was a problem hiding this comment.
We need to move those for the import below - they are already in haystack.testing.document_store_async in main. We need to wait for the next release then to merge this.
Contributor
Author
There was a problem hiding this comment.
That also explains the 6 CI failures on
test_count_unique_metadata_by_filter_async_all_documents the current mixin in
haystack.testing.document_store uses sync write_documents, which initializes a separate
in-memory client from the async one used by count_unique_metadata_by_filter_async. So the
async client sees an empty store and returns 0.
I'll update the imports to haystack.testing.document_store_async once the next haystack
release ships those changes.
Closes deepset-ai#3052 Replaces duplicate async test implementations with the mixin classes from haystack.testing.document_store and haystack.testing.document_store_async. - Removes 19 tests now covered by the mixins - Keeps all Qdrant-specific tests (hybrid search, sparse config, collection setup validation, vector preservation)
…clients When using location=':memory:', QdrantClient and AsyncQdrantClient each create a separate in-memory store, so data written via the sync client is invisible to the async client and vice versa. Fix by sharing the underlying .collections and .aliases dicts after the second client is initialised, so both clients always see the same data. This makes mixed sync/async tests (e.g. sync write_documents + async count_unique_metadata_by_filter_async) work correctly with in-memory stores.
- Override assert_documents_are_equal to compare by ID set (Qdrant returns embedding vectors on all docs and doesn't guarantee order) - Override test_write_documents_async (base raises NotImplementedError by design, requires store-specific implementation) - Override test_count_not_empty_async to add missing self parameter (bug in haystack mixin causes fixture injection to fail)
SyedShahmeerAli12
force-pushed
the
refactor/qdrant-async-mixin-tests
branch
from
faa8e99 to
6ac1294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
▎ Closes #3052
▎ What this changes
▎ Refactors integrations/qdrant/tests/test_document_store_async.py to inherit from the async
mixin classes introduced in deepset-ai/haystack#10799.
▎ - Removes 19 duplicate tests now covered by the mixins
▎ - Keeps all Qdrant-specific tests (hybrid search, sparse config, collection setup
validation, vector preservation)
▎ - Adds FilterDocumentsAsyncTest and CountDocumentsAsyncTest since Qdrant implements both
filter_documents_async and count_documents_async