refactor(pgvector): use async DocumentStore mixin tests#3094
Open
SyedShahmeerAli12 wants to merge 2 commits intodeepset-ai:mainfrom
Open
refactor(pgvector): use async DocumentStore mixin tests#3094SyedShahmeerAli12 wants to merge 2 commits intodeepset-ai:mainfrom
SyedShahmeerAli12 wants to merge 2 commits intodeepset-ai:mainfrom
Conversation
Closes deepset-ai#3052 Replaces duplicate async test implementations with the mixin classes from haystack.testing.document_store and haystack.testing.document_store_async. - Removes 19 tests now covered by the mixins - Keeps all Qdrant-specific tests (hybrid search, sparse config, collection setup validation, vector preservation)
Closes deepset-ai#3050 Replaces duplicate async test implementations with mixin classes from haystack.testing.document_store and haystack.testing.document_store_async. - Removes 17 tests now covered by the mixins - Keeps all pgvector-specific tests (blob write, connection recreation, invalid connection, empty meta validation, hnsw index, table management)
github-actions
bot
added
integration:qdrant
integration:pgvector
type:documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #3050
What this changes
Refactors
integrations/pgvector/tests/test_document_store_async.pyto inherit from the async mixin classes introduced in deepset-ai/haystack#10799.