-
Notifications
You must be signed in to change notification settings - Fork 243
refactor(pgvector): use async DocumentStore mixin tests #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SyedShahmeerAli12
wants to merge
10
commits into
deepset-ai:main
Choose a base branch
from
SyedShahmeerAli12:refactor/pgvector-async-mixin-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
09aa131
refactor(qdrant): use async DocumentStore mixin tests
SyedShahmeerAli12 83cb151
refactor(pgvector): use async DocumentStore mixin tests
SyedShahmeerAli12 3ac764b
revert: restore qdrant async tests unchanged
SyedShahmeerAli12 1b63040
fix(pgvector): return None min/max for unknown/empty metadata field
SyedShahmeerAli12 2e72715
fix(pgvector): update local empty-collection min/max test to expect None
SyedShahmeerAli12 ec66402
fix(pgvector): return empty dict from get_metadata_fields_info on emp…
SyedShahmeerAli12 3160494
fix(pgvector): override assert_documents_are_equal in async test class
SyedShahmeerAli12 56ab780
fix(pgvector): fix lint error and override broken mixin test
SyedShahmeerAli12 57ebe2e
fix(pgvector): override test_write_documents_async with pgvector beha…
SyedShahmeerAli12 7eb8176
fix(pgvector): bump minimum haystack-ai to 2.27.0
SyedShahmeerAli12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use double back ticks in our api docstrings only single backticks