fix!: remap finish_reason to tool_calls when response contains tool calls#3102
Merged
sjrl merged 1 commit intodeepset-ai:mainfrom Apr 9, 2026
Conversation
github-actions
bot
added
integration:google-genai
type:documentation
…ntains tool calls
SyedShahmeerAli12
force-pushed
the
fix/google-genai-finish-reason-tool-calls
branch
from
447ec33 to
184a49e
Compare
Contributor
Author
|
@sjrl .. Google GenAI has no dedicated FUNCTION_CALL finish reason ..... it returns STOP for both normal |
sjrl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2143.
Google GenAI returns
STOPasfinish_reasonfor both normal completions and tool calls (it has no dedicatedFUNCTION_CALLfinish reason). This makes the response indistinguishable from a normal text completion, breaking any downstream code that branches onfinish_reason.Fix: after mapping the raw Google finish reason, if the mapped value is
"stop"and the response contains tool calls, remap it to"tool_calls". Applied to both the non-streaming (_convert_google_genai_response_to_chatmessage) and streaming (_convert_google_chunk_to_streaming_chunk) paths.