-
Notifications
You must be signed in to change notification settings - Fork 262
fix(opensearch): pass positional args to transport.perform_request for ddtrace compatibility #3132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
ab68f1a
36e0483
c36c0b1
433e3d2
e3ead08
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2161,8 +2161,8 @@ def _query_sql(self, query: str, fetch_size: int | None = None) -> dict[str, Any | |
| body["fetch_size"] = fetch_size | ||
|
|
||
| response_data = self._client.transport.perform_request( | ||
| method="POST", | ||
| url="/_plugins/_sql", | ||
| "POST", | ||
| "/_plugins/_sql", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's add a comment explaining why we use positional args here, so we don't forget in the future |
||
| body=body, | ||
| ) | ||
|
|
||
|
|
@@ -2194,8 +2194,8 @@ async def _query_sql_async(self, query: str, fetch_size: int | None = None) -> d | |
| body["fetch_size"] = fetch_size | ||
|
|
||
| response_data = await self._async_client.transport.perform_request( | ||
| method="POST", | ||
| url="/_plugins/_sql", | ||
| "POST", | ||
| "/_plugins/_sql", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's add a comment explaining why we use positional args here, so we don't forget in the future |
||
| body=body, | ||
| ) | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.