Skip to content

fix: fix GoogleGenAIMultimodalDocumentEmbedder input format#3136

Merged
anakin87 merged 1 commit into
mainfrom
genai-multimodal-input-fmt
Apr 13, 2026
Merged

fix: fix GoogleGenAIMultimodalDocumentEmbedder input format#3136
anakin87 merged 1 commit into
mainfrom
genai-multimodal-input-fmt

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 13, 2026

Related Issues

Proposed Changes:

  • in GoogleGenAIMultimodalDocumentEmbedder, adopt stricter input to GenAI SDK (now mandatory)

How did you test it?

CI

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report (google_genai)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/google_genai/src/haystack_integrations/components/embedders/google_genai
  document_embedder.py
  multimodal_document_embedder.py
Project Total  

This report was generated by python-coverage-comment-action

@@ -204,10 +203,11 @@ def _embed_batch(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are unrelated to the bug and I only made them for consistency

@anakin87 anakin87 marked this pull request as ready for review April 13, 2026 07:53
@anakin87 anakin87 requested a review from a team as a code owner April 13, 2026 07:53
@anakin87 anakin87 requested review from bogdankostic and removed request for a team April 13, 2026 07:53
@anakin87 anakin87 self-assigned this Apr 13, 2026
@anakin87 anakin87 merged commit 0862847 into main Apr 13, 2026
13 checks passed
@anakin87 anakin87 deleted the genai-multimodal-input-fmt branch April 13, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants