fix: replace in place dataclass mutations for pgvector #11087#3142
Merged
davidsbatista merged 3 commits intodeepset-ai:mainfrom Apr 13, 2026
Merged
Conversation
|
|
Contributor
Coverage report (pgvector)
This PR does not seem to contain any modification to coverable code. |
HuyDC
changed the title
HuyDC
changed the title
davidsbatista
approved these changes
Apr 13, 2026
Contributor
davidsbatista
left a comment
davidsbatista
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the contribution!
Contributor
|
@HuyDC, please sign the CLA so we can merge it. Thanks once again for your contribution! |
HuyDC
deleted the
fix-replace-in-place-dataclass-mutations-pgvector-11087
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
PGVectorDocumentStoredataclass in-place mutation warning haystack#11087Proposed Changes:
Replace dataclass objects when modifying instead of mutating in place.
How did you test it?
Ran all unit tests and integration tests and check if in place replacement warning still occurs.
hatch run fmt and hatch run test:all pass
Notes for the reviewer
New variables are created, because linter does not like manipulating the loop variables.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.