From 033a9fc7aaae39351098c70f3a522f33f83b2c88 Mon Sep 17 00:00:00 2001 From: HuyDC <26975814+HuyDC@users.noreply.github.com> Date: Mon, 13 Apr 2026 12:31:44 +0200 Subject: [PATCH 1/2] fix: use replace to set attr to None [11087] --- integrations/pgvector/tests/test_filters.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/integrations/pgvector/tests/test_filters.py b/integrations/pgvector/tests/test_filters.py index 6787448239..c312a20d2f 100644 --- a/integrations/pgvector/tests/test_filters.py +++ b/integrations/pgvector/tests/test_filters.py @@ -17,6 +17,7 @@ _treat_meta_field, _validate_filters, ) +from dataclasses import replace def _render(composed: Composed) -> str: @@ -42,7 +43,8 @@ def assert_documents_are_equal(self, received: list[Document], expected: list[Do else: assert received_doc.embedding == pytest.approx(expected_doc.embedding) - received_doc.embedding, expected_doc.embedding = None, None + received_doc = replace(received_doc, embedding=None) + expected_doc = replace(expected_doc, embedding=None) assert received_doc == expected_doc @pytest.mark.skip(reason="NOT operator is not supported in PgvectorDocumentStore") From d6c375eb694456e848a9274dad85e7c15d83f165 Mon Sep 17 00:00:00 2001 From: HuyDC <26975814+HuyDC@users.noreply.github.com> Date: Mon, 13 Apr 2026 12:34:07 +0200 Subject: [PATCH 2/2] fix: avoid linting error reassigning loop vars [11087] --- integrations/pgvector/tests/test_filters.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/integrations/pgvector/tests/test_filters.py b/integrations/pgvector/tests/test_filters.py index c312a20d2f..246e9a325f 100644 --- a/integrations/pgvector/tests/test_filters.py +++ b/integrations/pgvector/tests/test_filters.py @@ -2,6 +2,8 @@ # # SPDX-License-Identifier: Apache-2.0 +from dataclasses import replace + import pytest from haystack.dataclasses.document import Document from haystack.testing.document_store import FilterDocumentsTest @@ -17,7 +19,6 @@ _treat_meta_field, _validate_filters, ) -from dataclasses import replace def _render(composed: Composed) -> str: @@ -43,9 +44,9 @@ def assert_documents_are_equal(self, received: list[Document], expected: list[Do else: assert received_doc.embedding == pytest.approx(expected_doc.embedding) - received_doc = replace(received_doc, embedding=None) - expected_doc = replace(expected_doc, embedding=None) - assert received_doc == expected_doc + received_doc_no_embedding = replace(received_doc, embedding=None) + expected_doc_no_embedding = replace(expected_doc, embedding=None) + assert received_doc_no_embedding == expected_doc_no_embedding @pytest.mark.skip(reason="NOT operator is not supported in PgvectorDocumentStore") def test_not_operator(self, document_store, filterable_docs): ...