Skip to content

feat: Astra - improve filters and add unit tests#3194

Merged
anakin87 merged 19 commits intomainfrom
astra-tests
Apr 27, 2026
Merged

feat: Astra - improve filters and add unit tests#3194
anakin87 merged 19 commits intomainfrom
astra-tests

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 21, 2026

Related Issues

Proposed Changes:

  • implement better filters, more aligned with Haystack defaults
  • add unit tests for Astra, focusing on uncovered code paths (with some AI help)
  • simplify/parametrize some existing tests

How did you test it?

CI

Checklist

@github-actions github-actions Bot added integration:astra type:documentation Improvements or additions to documentation labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Coverage report (astra)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/astra/src/haystack_integrations/components/retrievers/astra
  retriever.py
  integrations/astra/src/haystack_integrations/document_stores/astra
  astra_client.py
  document_store.py
  filters.py 68, 70, 74, 86-87, 108-109, 128, 130-134, 139, 146, 153, 160, 174-175
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 marked this pull request as ready for review April 21, 2026 16:24
@anakin87 anakin87 requested a review from a team as a code owner April 21, 2026 16:24
@anakin87 anakin87 requested review from bogdankostic and removed request for a team April 21, 2026 16:24
@anakin87 anakin87 self-assigned this Apr 21, 2026
Copy link
Copy Markdown
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in principle, I was just wondering if we could remove the overwrites of the filter tests below this line, given that filters seem to be supported looking at test_filters_unit.py.

@anakin87 anakin87 marked this pull request as draft April 27, 2026 07:41
@anakin87 anakin87 changed the title test: Astra - add unit tests feat: Astra - improve filters and add unit tests Apr 27, 2026
@anakin87
Copy link
Copy Markdown
Member Author

Looking good in principle, I was just wondering if we could remove the overwrites of the filter tests below this line, given that filters seem to be supported looking at test_filters_unit.py.

Prompted by this comment, I decided to investigate better.

And I realized that we could not remove overwrites right away. So I decided to implement better filters for Astra (with some help from AI) and now filters are more aligned with Haystack defaults.

I also updated this PR description: #3194 (comment)

@anakin87 anakin87 marked this pull request as ready for review April 27, 2026 10:27
@anakin87 anakin87 requested a review from bogdankostic April 27, 2026 10:27
@anakin87 anakin87 merged commit 8298474 into main Apr 27, 2026
16 checks passed
@anakin87 anakin87 deleted the astra-tests branch April 27, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:astra type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astra document store filter tests are skipped

2 participants