Skip to content

test: fix MCP flaky tests#3200

Merged
anakin87 merged 1 commit intomainfrom
fix-mcp-flaky-test
Apr 22, 2026
Merged

test: fix MCP flaky tests#3200
anakin87 merged 1 commit intomainfrom
fix-mcp-flaky-test

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 22, 2026

Related Issues

On GitHub runners, it might happen that a timeout of 0.01s does not trigger on a 0.05s sleep because of scheduling delays

Proposed Changes:

  • use a hanging event instead of sleep

How did you test it?

CI

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report (mcp)

This PR does not seem to contain any modification to coverable code.

@anakin87 anakin87 marked this pull request as ready for review April 22, 2026 06:59
@anakin87 anakin87 requested a review from a team as a code owner April 22, 2026 06:59
@anakin87 anakin87 requested review from bogdankostic and removed request for a team April 22, 2026 06:59
@anakin87 anakin87 self-assigned this Apr 22, 2026
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87 anakin87 merged commit ab53b79 into main Apr 22, 2026
13 checks passed
@anakin87 anakin87 deleted the fix-mcp-flaky-test branch April 22, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants