chore: hanlp - avoid mutating documents and add tests#3206
Merged
Conversation
Contributor
Coverage report (hanlp)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
davidsbatista
approved these changes
Apr 22, 2026
Contributor
davidsbatista
left a comment
davidsbatista
left a comment
There was a problem hiding this comment.
Looks good!
deepset-ai/haystack#10956 -> please don't forget to update the PR so we know which integrations need to be fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.