Skip to content

test: valkey - add unit tests#3210

Merged
anakin87 merged 1 commit into
mainfrom
valkey-tests
Apr 23, 2026
Merged

test: valkey - add unit tests#3210
anakin87 merged 1 commit into
mainfrom
valkey-tests

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 23, 2026

Related Issues

Proposed Changes:

  • add unit tests for valkey, focusing on uncovered code paths (with some AI help)

How did you test it?

CI

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report (valkey)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/valkey/src/haystack_integrations/document_stores/valkey
  document_store.py
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 marked this pull request as ready for review April 23, 2026 08:02
@anakin87 anakin87 requested a review from a team as a code owner April 23, 2026 08:02
@anakin87 anakin87 requested review from sjrl and removed request for a team April 23, 2026 08:02
@anakin87 anakin87 self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87 anakin87 merged commit aae36f1 into main Apr 23, 2026
11 checks passed
@anakin87 anakin87 deleted the valkey-tests branch April 23, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants