Skip to content

ci: add workflow to notify maintainers on fork PRs not running integration tests#3211

Merged
anakin87 merged 4 commits into
mainfrom
comment-for-maintainers
Apr 27, 2026
Merged

ci: add workflow to notify maintainers on fork PRs not running integration tests#3211
anakin87 merged 4 commits into
mainfrom
comment-for-maintainers

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 23, 2026

Related Issues

We don't expose secrets on PRs from forks for security reasons.

This also means that integration tests are skipped if API keys are required. In these cases, the maintainer should run the tests locally before merging the PR.

Proposed Changes:

  • add a workflow for detecting PRs from forks where tests will be skipped and comment on the PR

How did you test it?

Hard to test. I'll test when merged and fix if not working properly.

Checklist

@anakin87 anakin87 marked this pull request as ready for review April 23, 2026 08:48
@anakin87 anakin87 requested a review from a team as a code owner April 23, 2026 08:48
@anakin87 anakin87 requested review from julian-risch and removed request for a team April 23, 2026 08:48
@anakin87 anakin87 self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only checking out the base branch SHA (the trusted target branch), not head.sha (the fork's code). Further ${{ steps.affected.outputs.list }} can only contain known integration names, no other content.
marocchino/sticky-pull-request-comment is a GitHub action that we're not using anywhere else yet. Looks good to me. They enabled immutable releases on GitHub two weeks ago, which is good. Still, let's keep in mind that another GitHub action means an additional risk and we could for example fork the action.

@anakin87 anakin87 merged commit bc3284f into main Apr 27, 2026
6 checks passed
@anakin87 anakin87 deleted the comment-for-maintainers branch April 27, 2026 07:20
@anakin87
Copy link
Copy Markdown
Member Author

It works. See #3234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants