Skip to content

test: pinecone - add unit tests#3218

Merged
anakin87 merged 2 commits intomainfrom
pinecone-unit
Apr 23, 2026
Merged

test: pinecone - add unit tests#3218
anakin87 merged 2 commits intomainfrom
pinecone-unit

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 23, 2026

Related Issues

Proposed Changes:

  • add a few unit tests for Pinecone, focusing on uncovered code paths (with some AI help)

How did you test it?

CI

Checklist

@github-actions github-actions Bot added integration:pinecone type:documentation Improvements or additions to documentation labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Coverage report (pinecone)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/pinecone/src/haystack_integrations/components/retrievers/pinecone
  embedding_retriever.py
  integrations/pinecone/src/haystack_integrations/document_stores/pinecone
  document_store.py
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 self-assigned this Apr 23, 2026
@anakin87 anakin87 marked this pull request as ready for review April 23, 2026 13:27
@anakin87 anakin87 requested a review from a team as a code owner April 23, 2026 13:27
@anakin87 anakin87 requested review from davidsbatista and removed request for a team April 23, 2026 13:28
@davidsbatista
Copy link
Copy Markdown
Contributor

Thanks for this 👍🏽

As you keep extending the test coverage if you notice that one is being repeated throughout the different doc stores, then it's probably time to move it to Mixin.

@anakin87
Copy link
Copy Markdown
Member Author

As you keep extending the test coverage if you notice that one is being repeated throughout the different doc stores, then it's probably time to move it to Mixin.

Good idea, will take a look

@anakin87 anakin87 merged commit 59a2f4c into main Apr 23, 2026
11 checks passed
@anakin87 anakin87 deleted the pinecone-unit branch April 23, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:pinecone type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants