refactor: Google GenAI embedders - adaptations for Gemini Embedding 2 general availability#3251
Merged
refactor: Google GenAI embedders - adaptations for Gemini Embedding 2 general availability#3251
Conversation
… general availability
github-actions
Bot
added
the
type:documentation
Contributor
Coverage report (google_genai)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
sjrl
reviewed
Apr 29, 2026
Comment on lines
104
to
107
| :param prefix: | ||
| A string to add at the beginning of each text. | ||
| :param suffix: | ||
| A string to add at the end of each text. |
Contributor
There was a problem hiding this comment.
Do you think it would be worth linking these docs https://ai.google.dev/gemini-api/docs/embeddings#task-types-embeddings-2 for suggested prefixes that users could/should set?
sjrl
approved these changes
Apr 29, 2026
Contributor
sjrl
left a comment
sjrl
left a comment
There was a problem hiding this comment.
One minor comment otherwise looks good!
…et-ai/haystack-core-integrations into gemini-embedding-2-updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
CI, new tests, tested with this notebook (needs minor updates);
local tests pass, CI is failing due to resource exhausted
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.