Skip to content

chore!: Azure AI - adaptations for the new SDK#3269

Merged
anakin87 merged 2 commits into
mainfrom
azure-search-types
May 4, 2026
Merged

chore!: Azure AI - adaptations for the new SDK#3269
anakin87 merged 2 commits into
mainfrom
azure-search-types

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented May 4, 2026

Related Issues

Proposed Changes:

  • adapt to new SDK
    • changed serde behaviors
    • fixed types
    • updated tests

How did you test it?

CI

Notes for the reviewer

A document store serialized with the old integration version/SDK might fail deserialization. However, it's hard to map all their changes in a clean way, so I am planning to release a new major version with this breaking change.

Checklist

@github-actions github-actions Bot added integration:azure-ai-search type:documentation Improvements or additions to documentation labels May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Coverage report (azure_ai_search)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search
  document_store.py 290, 617-620, 772
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 self-assigned this May 4, 2026
@anakin87 anakin87 marked this pull request as ready for review May 4, 2026 12:56
@anakin87 anakin87 requested a review from a team as a code owner May 4, 2026 12:56
@anakin87 anakin87 requested review from sjrl and removed request for a team May 4, 2026 12:56
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man all sorts of breaking changes, thanks for the fix!

@anakin87 anakin87 changed the title chore: Azure AI - adaptations for the new SDK chore!: Azure AI - adaptations for the new SDK May 4, 2026
@anakin87 anakin87 merged commit dc4b9fe into main May 4, 2026
15 checks passed
@anakin87 anakin87 deleted the azure-search-types branch May 4, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:azure-ai-search type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants