Skip to content

chore: Valkey - improve typing #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anakin87 merged 1 commit into from
May 7, 2026
Merged

chore: Valkey - improve typing #3285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,9 @@ def delete_documents(self, document_ids: list[str]) -> None:
"""
client = self._get_connection()

keys: list[str | bytes] = [f"{self._index_name}:{doc_id}" for doc_id in document_ids]
keys: list[str | bytes | bytearray | memoryview[int]] = [
f"{self._index_name}:{doc_id}" for doc_id in document_ids
]
try:
result = client.delete(keys)
if result < len(document_ids):
Expand Down Expand Up @@ -770,7 +772,9 @@ async def delete_documents_async(self, document_ids: list[str]) -> None:
"""
client = await self._get_connection_async()

keys: list[str | bytes] = [f"{self._index_name}:{doc_id}" for doc_id in document_ids]
keys: list[str | bytes | bytearray | memoryview[int]] = [
f"{self._index_name}:{doc_id}" for doc_id in document_ids
]
try:
result = await client.delete(keys)
if result < len(document_ids):
Expand Down
Loading