feat(falkordb): add missing DocumentStore operations#3292
Merged
bogdankostic merged 4 commits intoMay 15, 2026
Merged
Conversation
SyedShahmeerAli12
requested review from
bogdankostic
and removed request for
a team
github-actions
Bot
added
integration:docling
integration:falkordb
type:documentation
SyedShahmeerAli12
force-pushed
the
feat/falkordb-missing-operations
branch
from
6423d1f to
cfbc90e
Compare
Contributor
Coverage report (falkordb)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
Author
|
@bogdankostic All fixes are done and CI checks are passing |
Contributor
bogdankostic
left a comment
bogdankostic
left a comment
There was a problem hiding this comment.
Thanks @SyedShahmeerAli12! This PR looks good in general, could you just make sure to use single backticks for in-line code blocks inside doc strings.
Also, would you mind adding some unit tests for the added functionality? We woudl like to keep unit test coverage high.
Contributor
Author
|
Fixed the docstring backticks and added unit tests for all new methods |
bogdankostic
approved these changes
May 15, 2026
Contributor
bogdankostic
left a comment
bogdankostic
left a comment
There was a problem hiding this comment.
Looking good, thanks @SyedShahmeerAli12! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Adds the 8 missing
DocumentStoremethods toFalkorDBDocumentStore:delete_all_documents()delete_by_filter(filters)update_by_filter(filters, meta)count_documents_by_filter(filters)count_unique_metadata_by_filter(filters, metadata_fields)get_metadata_fields_info()get_metadata_field_min_max(metadata_field)get_metadata_field_unique_values(metadata_field, search_term, size, after)All methods use OpenCypher queries and reuse the existing
_convert_filtershelper. The test class now inherits the corresponding Haystack mixin test classes covering the new methods.How did you test it?
hatch run test:unit13/13 passinghatch run test:typesno issuesdocker run -p 6379:6379 falkordb/falkordb)Notes for the reviewer
get_metadata_fields_info()samples node property keys and infers Python types since FalkorDB is schema-less (no index mapping API like Elasticsearch)get_metadata_field_unique_values()uses offset-based pagination via theaftercursorChecklist
feat: