Skip to content

fix: adaptations for changes in Weave settings#3304

Merged
anakin87 merged 1 commit into
mainfrom
fix-weave
May 15, 2026
Merged

fix: adaptations for changes in Weave settings#3304
anakin87 merged 1 commit into
mainfrom
fix-weave

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented May 15, 2026

Related Issues

Proposed Changes:

  • if UserSettings is a dataclass, use asdict to serialize it. Keep backward compatibility

How did you test it?

CI, adapted a test

Checklist

@github-actions github-actions Bot added the integration:weave components coming from Weights and Biases label May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Coverage report (weave)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/weave/src/haystack_integrations/components/connectors/weave
  weave_connector.py 116
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 marked this pull request as ready for review May 15, 2026 06:35
@anakin87 anakin87 requested a review from a team as a code owner May 15, 2026 06:35
@anakin87 anakin87 requested review from bogdankostic and removed request for a team May 15, 2026 06:35
@anakin87 anakin87 self-assigned this May 15, 2026
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anakin87 anakin87 merged commit 9c826ed into main May 15, 2026
16 checks passed
@anakin87 anakin87 deleted the fix-weave branch May 15, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:weave components coming from Weights and Biases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants