fix: support aliases in all OpenSearchDocumentStore methods#3336
Merged
Conversation
Contributor
Coverage report (opensearch)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
OpenSearch's indices.get_mapping() and indices.get() APIs always key their response by the real (concrete) index name, not by the alias name used in the request. Every call site that did mapping[self._index] would raise KeyError when self._index was an alias.
Proposed Changes:
document_store.py — 6 call sites fixed using actual_index = next(iter(response)):
Alias guard for destructive recreation: delete_all_documents(recreate_index=True) now raises DocumentStoreError early when self._index is an alias. Deleting and recreating through an alias would drop the backing index and create a new concrete index named after the alias, permanently breaking the alias relationship. The recreate_index=False (delete-by-query) path is unaffected and works normally with aliases.
How did you test it?
Unit tests (mocked):
Integration tests:
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.