Fix: use AsyncPipeline with OpensearchHybridRetriever super_component#3369
Open
Nitro963 wants to merge 4 commits into
Open
Fix: use AsyncPipeline with OpensearchHybridRetriever super_component#3369Nitro963 wants to merge 4 commits into
Nitro963 wants to merge 4 commits into
Conversation
Contributor
Coverage report (opensearch)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
Coverage report (elasticsearch)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
|
Hey @Nitro963 thanks for the contribution! Could you separate these changes into two separate PRs, so one for OpenSearch and one for ElasticSearch? It helps keep our release notes for the different packages well separated. |
Nitro963
force-pushed
the
hybrid-retriever-async
branch
from
859d54f to
2a1464a
Compare
Nitro963
changed the title
Contributor
Author
Contributor
|
@Nitro963 thanks! Please also drop the changes to the elastic search integration in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Use AsyncPipeline so that OpensearchHybridRetriever component work within sync and async pipelines
How did you test it?
Created Unit tests for usage within async pipelines