Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ def from_dict(cls, data: dict[str, Any]) -> "LangfuseConnector":
"""
init_params = data["init_parameters"]
deserialize_secrets_inplace(init_params, keys=["secret_key", "public_key"])
init_params["span_handler"] = (
deserialize_class_instance(init_params["span_handler"]) if init_params["span_handler"] else None
)
if init_params.get("span_handler") is not None:
init_params["span_handler"] = deserialize_class_instance(init_params["span_handler"])
return default_from_dict(cls, data)
31 changes: 31 additions & 0 deletions integrations/langfuse/tests/test_langfuse_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,37 @@ def test_from_dict(self, monkeypatch):
assert langfuse_connector.host is None
assert langfuse_connector.langfuse_client_kwargs is None

def test_from_dict_without_span_handler(self, monkeypatch):
monkeypatch.setenv("LANGFUSE_SECRET_KEY", "secret")
monkeypatch.setenv("LANGFUSE_PUBLIC_KEY", "public")

# All keys that would point to None (span_handler, host, langfuse_client_kwargs) are intentionally absent
data = {
"type": "haystack_integrations.components.connectors.langfuse.langfuse_connector.LangfuseConnector",
"init_parameters": {
"name": "Chat example - OpenAI",
"public": False,
"secret_key": {
"type": "env_var",
"env_vars": ["LANGFUSE_SECRET_KEY"],
"strict": True,
},
"public_key": {
"type": "env_var",
"env_vars": ["LANGFUSE_PUBLIC_KEY"],
"strict": True,
},
},
}
langfuse_connector = LangfuseConnector.from_dict(data)
assert langfuse_connector.name == "Chat example - OpenAI"
assert langfuse_connector.public is False
assert langfuse_connector.secret_key == Secret.from_env_var("LANGFUSE_SECRET_KEY")
assert langfuse_connector.public_key == Secret.from_env_var("LANGFUSE_PUBLIC_KEY")
assert langfuse_connector.span_handler is None
assert langfuse_connector.host is None
assert langfuse_connector.langfuse_client_kwargs is None

def test_from_dict_with_params(self, monkeypatch):
monkeypatch.setenv("LANGFUSE_SECRET_KEY", "secret")
monkeypatch.setenv("LANGFUSE_PUBLIC_KEY", "public")
Expand Down
Loading