Skip to content

adding allow-unsafe-pr-checkout: true to CI_docstring_labeler.yml#3484

Merged
davidsbatista merged 2 commits into
mainfrom
fix/docstring-sum
Jun 22, 2026
Merged

adding allow-unsafe-pr-checkout: true to CI_docstring_labeler.yml#3484
davidsbatista merged 2 commits into
mainfrom
fix/docstring-sum

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes:

  • CI_docstring_labeler.yml workflow uses pull_request_target and deliberately checks out the fork's HEAD to compare docstring checksums.

  • The recent bump of actions/checkout from v6.0.2 → v6.0.3 (commit 76f9049) introduced a new security enforcement that now blocks this unless allow-unsafe-pr-checkout: true is explicitly set.

  • Why it's safe to opt in here: The workflow was already designed with this security concern in mind — the Python script is copied from the trusted base branch into $runner.temp before the fork checkout happens (step "Copy file", line 22). That script then runs on the fork's files to compute a docstring checksum. No code from the fork is ever executed; it's only read as data. No custom secrets are used either, only GITHUB_TOKEN.

How did you test it?

  • CI tests

Notes for the reviewer

Checklist

@davidsbatista davidsbatista marked this pull request as ready for review June 22, 2026 13:25
@davidsbatista davidsbatista requested a review from a team as a code owner June 22, 2026 13:25
@davidsbatista davidsbatista requested review from anakin87 and removed request for a team June 22, 2026 13:25

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

BTW, the PR that changed the actions/checkout version is #3472 (not the commit originally mentioned).

@davidsbatista davidsbatista merged commit 5949c99 into main Jun 22, 2026
7 checks passed
@davidsbatista davidsbatista deleted the fix/docstring-sum branch June 22, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants