Skip to content

chore: Remove Agent after Haystack 2.12 release#263

Merged
julian-risch merged 6 commits intomainfrom
remove-agent
Apr 10, 2025
Merged

chore: Remove Agent after Haystack 2.12 release#263
julian-risch merged 6 commits intomainfrom
remove-agent

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Apr 3, 2025

Related Issues

Proposed Changes:

  • Remove Agent, State, ToolInvoker, Tool, ComponentTool
  • Remove GitHub Issue resolver agent example
  • Remove pydocs

How did you test it?

Notes for the reviewer

Checklist

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 3, 2025

Pull Request Test Coverage Report for Build 14243735868

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.6%) to 85.127%

Totals Coverage Status
Change from base Build 14239876064: -3.6%
Covered Lines: 435
Relevant Lines: 511

💛 - Coveralls

@julian-risch julian-risch marked this pull request as ready for review April 3, 2025 13:04
@julian-risch julian-risch requested review from a team as code owners April 3, 2025 13:04
@julian-risch julian-risch requested review from dfokina and sjrl and removed request for a team April 3, 2025 13:04
@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Apr 3, 2025

@julian-risch for the Github components do you think it would be worth making an integration out of them?

@julian-risch
Copy link
Copy Markdown
Member Author

Ah, yes, that seems like a good option. I was wondering where we could keep them. The alternative of keeping them in experimental or deleting them entirely are not as good.

@julian-risch
Copy link
Copy Markdown
Member Author

I opened two draft PRs so that we can move forward.
deepset-ai/haystack-core-integrations#1637
deepset-ai/haystack-cookbook#183

Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julian-risch julian-risch merged commit e8b1048 into main Apr 10, 2025
10 checks passed
@julian-risch julian-risch deleted the remove-agent branch April 10, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants