Skip to content

Remove telemetry cells#400

Merged
bilgeyucel merged 1 commit intomainfrom
remove-telemetry
Jun 10, 2025
Merged

Remove telemetry cells#400
bilgeyucel merged 1 commit intomainfrom
remove-telemetry

Conversation

@bilgeyucel
Copy link
Copy Markdown
Contributor

@bilgeyucel bilgeyucel commented May 14, 2025

No description provided.

@bilgeyucel bilgeyucel requested a review from julian-risch May 14, 2025 11:48
@bilgeyucel bilgeyucel self-assigned this May 14, 2025
@bilgeyucel bilgeyucel requested a review from a team as a code owner May 14, 2025 11:48
@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented May 14, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

julian-risch
julian-risch requested changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of unrelated changes (10k+ lines) in tutorials/44_Creating_Custom_SuperComponents.ipynb and in tutorials/41_Query_Classification_with_TransformersTextRouter_and_TransformersZeroShotTextRouter.ipynb
Let's revert those changes and only remove the telemetry cell. All other files look good to me!

@bilgeyucel
Copy link
Copy Markdown
Contributor Author

bilgeyucel commented May 27, 2025

There are lots of unrelated changes (10k+ lines) in tutorials/44_Creating_Custom_SuperComponents.ipynb and in tutorials/41_Query_Classification_with_TransformersTextRouter_and_TransformersZeroShotTextRouter.ipynb Let's revert those changes and only remove the telemetry cell. All other files look good to me!

Those changes are due to formatting by pre-commit hooks. There's nothing we add or remove

julian-risch
julian-risch approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@bilgeyucel bilgeyucel merged commit e26b663 into main Jun 10, 2025
29 of 30 checks passed
@bilgeyucel bilgeyucel deleted the remove-telemetry branch June 10, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees

@bilgeyucel bilgeyucel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bilgeyucel @julian-risch