Skip to content

Commit 4c89081

Browse files
authored
fix: Add missing init param to to_dict in hf doc embedder (#11320)
1 parent 9da306b commit 4c89081

3 files changed

Lines changed: 9 additions & 0 deletions

File tree

haystack/components/embedders/hugging_face_api_document_embedder.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ def to_dict(self) -> dict[str, Any]:
211211
progress_bar=self.progress_bar,
212212
meta_fields_to_embed=self.meta_fields_to_embed,
213213
embedding_separator=self.embedding_separator,
214+
concurrency_limit=self.concurrency_limit,
214215
)
215216

216217
@classmethod
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
fixes:
3+
- |
4+
Fixed ``HuggingFaceAPIDocumentEmbedder`` serialization to preserve the configured ``concurrency_limit``.

test/components/embedders/test_hugging_face_api_document_embedder.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ def test_to_dict(self, mock_check_valid_model):
107107
progress_bar=False,
108108
meta_fields_to_embed=["meta_field"],
109109
embedding_separator=" ",
110+
concurrency_limit=7,
110111
)
111112

112113
data = embedder.to_dict()
@@ -125,6 +126,7 @@ def test_to_dict(self, mock_check_valid_model):
125126
"progress_bar": False,
126127
"meta_fields_to_embed": ["meta_field"],
127128
"embedding_separator": " ",
129+
"concurrency_limit": 7,
128130
},
129131
}
130132

@@ -143,6 +145,7 @@ def test_from_dict(self, mock_check_valid_model):
143145
"progress_bar": False,
144146
"meta_fields_to_embed": ["meta_field"],
145147
"embedding_separator": " ",
148+
"concurrency_limit": 7,
146149
},
147150
}
148151

@@ -158,6 +161,7 @@ def test_from_dict(self, mock_check_valid_model):
158161
assert not embedder.progress_bar
159162
assert embedder.meta_fields_to_embed == ["meta_field"]
160163
assert embedder.embedding_separator == " "
164+
assert embedder.concurrency_limit == 7
161165

162166
def test_prepare_texts_to_embed_w_metadata(self):
163167
documents = [

0 commit comments

Comments
 (0)