fix: prevent GeneratedAnswer.from_dict crash on empty all_messages (#11626)

Co-authored-by: David S. Batista <dsbatista@gmail.com>

Author: i-anubhav-anand

haystack/dataclasses/answer.py

@@ -139,7 +139,7 @@ def from_dict(cls, data: dict[str, Any]) -> "GeneratedAnswer":
             init_params["documents"] = [Document.from_dict(d) for d in documents]
 
         meta = init_params.get("meta", {})
-        if (all_messages := meta.get("all_messages")) is not None and isinstance(all_messages[0], dict):
+        if (all_messages := meta.get("all_messages")) and isinstance(all_messages[0], dict):
             meta["all_messages"] = [ChatMessage.from_dict(m) for m in all_messages]
         init_params["meta"] = meta
 

releasenotes/notes/fix-generated-answer-empty-all-messages-ffccf61b751bc344.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixed ``GeneratedAnswer.from_dict`` raising an ``IndexError`` when the serialized
+    ``meta`` contained an empty ``all_messages`` list. Deserialization now guards
+    against the empty list (consistent with ``to_dict``) and round-trips correctly.

test/dataclasses/test_answer.py

@@ -264,6 +264,26 @@ def test_from_dict_with_chat_message_in_meta(self):
         assert answer.meta["meta_key"] == "meta_value"
         assert answer.meta["all_messages"] == [ChatMessage.from_user("What is the answer?")]
 
+    def test_from_dict_with_empty_all_messages(self):
+        # An empty `all_messages` list must not crash deserialization: `is not None`
+        # let `[]` through and then indexed `all_messages[0]`, raising IndexError.
+        answer = GeneratedAnswer.from_dict(
+            {
+                "type": "haystack.dataclasses.answer.GeneratedAnswer",
+                "init_parameters": {
+                    "data": "42",
+                    "query": "What is the answer?",
+                    "documents": [],
+                    "meta": {"all_messages": []},
+                },
+            }
+        )
+        assert answer.meta["all_messages"] == []
+
+    def test_to_dict_from_dict_round_trip_with_empty_all_messages(self):
+        answer = GeneratedAnswer(data="42", query="What is the answer?", documents=[], meta={"all_messages": []})
+        assert GeneratedAnswer.from_dict(answer.to_dict()) == answer
+
     def test_no_warning_on_init(self):
         with warnings.catch_warnings():
             warnings.simplefilter("error", Warning)