Skip to content

Commit 91e71ee

Browse files
authored
drop ignores not being used (#11066)
1 parent 46dfbd5 commit 91e71ee

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

haystack/components/embedders/backends/sentence_transformers_backend.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,4 @@ def __init__(
111111
)
112112

113113
def embed(self, data: list[str] | list["Image"], **kwargs: Any) -> list[list[float]]:
114-
# Sentence Transformers encode can work with Images, but the type hint does not reflect that
115-
# https://sbert.net/examples/sentence_transformer/applications/image-search
116-
return self.model.encode(data, **kwargs).tolist() # type: ignore[arg-type]
114+
return self.model.encode(data, **kwargs).tolist()

haystack/components/embedders/backends/sentence_transformers_sparse_backend.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ def embed(self, *, data: list[str], **kwargs: Any) -> list[SparseEmbedding]:
113113

114114
sparse_embeddings: list[SparseEmbedding] = []
115115
for embedding_tensor in embeddings_list:
116-
# encode returns a list of tensors with the parameters above, but the type hint is too broad
117-
embedding_tensor = embedding_tensor.coalesce() # type: ignore[union-attr]
116+
embedding_tensor = embedding_tensor.coalesce()
118117
indices = embedding_tensor.indices()[0].tolist() # Only column indices
119118
values = embedding_tensor.values().tolist()
120119
sparse_embeddings.append(SparseEmbedding(indices=indices, values=values))

0 commit comments

Comments
 (0)