Skip to content

Commit 96f653f

Browse files
RajanChavadasjrl
andauthored
test: remove stale TODO and disambiguate PEP 585 param ids in type-utils test (#11866)
Co-authored-by: Sebastian Husch Lee <10526848+sjrl@users.noreply.github.com>
1 parent 0767418 commit 96f653f

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

test/core/test_type_utils.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -616,11 +616,10 @@ def test_partially_overlapping_unions_are_not_compatible_strict(sender_type, rec
616616
pytest.param(Dict[str, int], Dict, id="dict-of-primitive-to-bare-dict"),
617617
pytest.param(Set[float], Set, id="set-of-primitive-to-bare-set"),
618618
pytest.param(Tuple[int, str], Tuple, id="tuple-of-primitive-to-bare-tuple"),
619-
# TODO These tests are failing
620-
pytest.param(list[int], list, id="list-of-primitive-to-bare-list"),
621-
pytest.param(dict[str, int], dict, id="dict-of-primitive-to-bare-dict"),
622-
pytest.param(set[float], set, id="set-of-primitive-to-bare-set"),
623-
pytest.param(tuple[int, str], tuple, id="tuple-of-primitive-to-bare-tuple"),
619+
pytest.param(list[int], list, id="list-of-primitive-to-bare-list-pep585"),
620+
pytest.param(dict[str, int], dict, id="dict-of-primitive-to-bare-dict-pep585"),
621+
pytest.param(set[float], set, id="set-of-primitive-to-bare-set-pep585"),
622+
pytest.param(tuple[int, str], tuple, id="tuple-of-primitive-to-bare-tuple-pep585"),
624623
],
625624
)
626625
def test_container_of_primitive_to_bare_container_strict(sender_type, receiver_type):

0 commit comments

Comments
 (0)