Skip to content

Commit bba3f8e

Browse files
committed
fest: format resource name
Signed-off-by: Ahmad Zidan <ahmad.zidan@traveloka.com>
1 parent cc3df29 commit bba3f8e

2 files changed

Lines changed: 12 additions & 4 deletions

File tree

haystack/tracing/datadog.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,8 @@ def _get_span_resource_name(operation_name: str, tags: Optional[Dict[str, Any]])
7272
if operation_name == _COMPONENT_RUN_OPERATION_NAME and tags:
7373
component_type = tags.get(_COMPONENT_TYPE_KEY, "")
7474
component_name = tags.get(_COMPONENT_NAME_KEY, "")
75-
resource_name = f"{component_type} {component_name}".strip()
7675

77-
return resource_name if resource_name else None
76+
return f"{component_type}: {component_name}"
7877

7978
return None
8079

test/tracing/test_datadog.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,24 @@ class TestDatadogTracer:
4747
def test_opentelemetry_tracer(self, datadog_tracer: ddTracer, capfd: CaptureFixture) -> None:
4848
tracer = DatadogTracer(datadog_tracer)
4949

50-
with tracer.trace("test") as span:
50+
component_tags = {
51+
"haystack.component.name": "test_component",
52+
"haystack.component.type": "TestType",
53+
"haystack.component.input": {"input_key": "input_value"},
54+
"haystack.component.output": {"output_key": "output_value"},
55+
}
56+
57+
with tracer.trace("haystack.component.run", tags=component_tags) as span:
5158
span.set_tag("key", "value")
5259

5360
traces = get_traces_from_console(capfd)
5461
assert len(traces) == 1
5562

5663
trace = traces[0]
5764

58-
assert trace["name"] == "test"
65+
assert trace["name"] == "haystack.component.run"
66+
assert "test_component" in trace["resource"]
67+
assert "TestType" in trace["resource"]
5968

6069
def test_tagging(self, datadog_tracer: ddTracer, capfd: CaptureFixture) -> None:
6170
tracer = DatadogTracer(datadog_tracer)

0 commit comments

Comments
 (0)