Skip to content

Commit dbd4a66

Browse files
committed
chore: remove unused raise_on_invalid_filter_syntax utility function
1 parent 3cfbaa2 commit dbd4a66

3 files changed

Lines changed: 6 additions & 11 deletions

File tree

haystack/utils/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"callable_serialization": ["deserialize_callable", "serialize_callable"],
1515
"device": ["ComponentDevice", "Device", "DeviceMap", "DeviceType"],
1616
"deserialization": ["deserialize_chatgenerator_inplace", "deserialize_component_inplace"],
17-
"filters": ["document_matches_filter", "raise_on_invalid_filter_syntax"],
17+
"filters": ["document_matches_filter"],
1818
"jinja2_extensions": ["Jinja2TimeExtension"],
1919
"jupyter": ["is_in_jupyter"],
2020
"misc": ["expit", "expand_page_range"],
@@ -37,7 +37,6 @@
3737
from .device import DeviceMap as DeviceMap
3838
from .device import DeviceType as DeviceType
3939
from .filters import document_matches_filter as document_matches_filter
40-
from .filters import raise_on_invalid_filter_syntax as raise_on_invalid_filter_syntax
4140
from .jinja2_extensions import Jinja2TimeExtension as Jinja2TimeExtension
4241
from .jupyter import is_in_jupyter as is_in_jupyter
4342
from .misc import expand_page_range as expand_page_range

haystack/utils/filters.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,6 @@
1212
from haystack.errors import FilterError
1313

1414

15-
def raise_on_invalid_filter_syntax(filters: dict[str, Any] | None = None) -> None:
16-
"""
17-
Raise an error if the filter syntax is invalid.
18-
"""
19-
if filters and ("operator" not in filters or "conditions" not in filters):
20-
msg = "Invalid filter syntax. See https://docs.haystack.deepset.ai/docs/metadata-filtering for details."
21-
raise FilterError(msg)
22-
23-
2415
def document_matches_filter(filters: dict[str, Any], document: Document | ByteStream) -> bool:
2516
"""
2617
Return whether `filters` match the Document or the ByteStream.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
upgrade:
3+
- |
4+
The ``raise_on_invalid_filter_syntax`` utility function has been removed. Its implementation was incorrect
5+
and never used across Haystack and Haystack Core Integrations.

0 commit comments

Comments
 (0)