Skip to content

feat: Add extra field in ToolCall and ToolCallDelta#10018

Merged
Amnah199 merged 3 commits into
mainfrom
add-extra-to-toolcall
Nov 5, 2025
Merged

feat: Add extra field in ToolCall and ToolCallDelta#10018
Amnah199 merged 3 commits into
mainfrom
add-extra-to-toolcall

Conversation

@Amnah199

@Amnah199 Amnah199 commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Related Issues

  • fixes Currently we are not able to store provider specific keys in tool calls.

Proposed Changes:

Add an extra dict in ToolCall and ToolCallDelta

How did you test it?

Update the tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@vercel

vercel Bot commented Nov 5, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
haystack-docs Ignored Ignored Preview Nov 5, 2025 0:04am

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Nov 5, 2025
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 19101366474

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 92.253%

Files with Coverage Reduction New Missed Lines %
dataclasses/chat_message.py 2 99.33%
dataclasses/streaming_chunk.py 3 95.77%
Totals Coverage Status
Change from base Build 19099376897: 0.001%
Covered Lines: 13515
Relevant Lines: 14650

💛 - Coveralls

@Amnah199 Amnah199 requested a review from sjrl November 5, 2025 12:30
@Amnah199 Amnah199 marked this pull request as ready for review November 5, 2025 12:30
@Amnah199 Amnah199 requested a review from a team as a code owner November 5, 2025 12:30

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Amnah199 Amnah199 merged commit 071d2f1 into main Nov 5, 2025
24 checks passed
@Amnah199 Amnah199 deleted the add-extra-to-toolcall branch November 5, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants