Skip to content

feat: adding QueryExpander, MultiQueryEmbeddingRetriever and MultiQueryTextRetriever#10126

Merged
davidsbatista merged 15 commits into
mainfrom
feat/adding-QueryExpander-MultiQueryRetriever
Nov 25, 2025
Merged

feat: adding QueryExpander, MultiQueryEmbeddingRetriever and MultiQueryTextRetriever#10126
davidsbatista merged 15 commits into
mainfrom
feat/adding-QueryExpander-MultiQueryRetriever

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

  • Adding 3 new components from experimental:
    • QueryExpander
    • MultiQueryEmbeddingRetriever
    • MultiQueryTextRetriever

How did you test it?

  • unit tests, integration tests + CI

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
haystack-docs Ignored Ignored Preview Nov 24, 2025 3:52pm

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Nov 24, 2025
@coveralls

coveralls commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 19640435406

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 91.539%
Files with Coverage Reduction New Missed Lines %
core/pipeline/async_pipeline.py 3 65.88%
Totals Coverage Status
Change from base Build 19637726908: 0.1%
Covered Lines: 13913
Relevant Lines: 15199
💛 - Coveralls

@davidsbatista davidsbatista changed the title Feat/adding query expander multi query retriever feat: adding QueryExpander, MultiQueryEmbeddingRetriever and MultiQueryTextRetriever Nov 24, 2025
@davidsbatista davidsbatista marked this pull request as ready for review November 24, 2025 14:05
@davidsbatista davidsbatista requested a review from a team as a code owner November 24, 2025 14:05
@davidsbatista davidsbatista requested review from Amnah199 and removed request for a team November 24, 2025 14:05
anakin87
anakin87 reviewed Nov 24, 2025
View reviewed changes

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments.

Let's also try to increase the coverage of these new components with unit tests. The coveralls report can help.

Comment thread docs/pydoc/config_docusaurus/query_api.yml Outdated
Comment thread haystack/components/query/query_expander.py Outdated
Comment thread haystack/components/retrievers/multi_query_embedding_retriever.py Outdated
Comment thread haystack/components/retrievers/multi_query_text_retriever.py Outdated
Comment thread releasenotes/notes/adding-QueryExpander-MultiQueryRetriever-88c4847894ea1fd0.yaml Outdated
davidsbatista and others added 4 commits November 24, 2025 15:26
@davidsbatista @anakin87
Update docs/pydoc/config_docusaurus/query_api.yml
a85313d 
Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
@davidsbatista @anakin87
Update haystack/components/query/query_expander.py
637f3ed 
Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
@davidsbatista @anakin87
Update releasenotes/notes/adding-QueryExpander-MultiQueryRetriever-88…
05f5784 
…c4847894ea1fd0.yaml

Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
@davidsbatista
Merge branch 'main' into feat/adding-QueryExpander-MultiQueryRetriever
4ea74f9
anakin87
anakin87 reviewed Nov 24, 2025
View reviewed changes
Comment thread test/components/query/test_query_expander.py Outdated
anakin87
anakin87 approved these changes Nov 24, 2025
View reviewed changes

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please also create a new issue to track the creation of documentation pages for these new components.

@davidsbatista davidsbatista merged commit 763174e into main Nov 25, 2025
22 of 23 checks passed
@davidsbatista davidsbatista deleted the feat/adding-QueryExpander-MultiQueryRetriever branch November 25, 2025 09:22
This was referenced Nov 27, 2025
Closed
Closed
@sachinn854 sachinn854 mentioned this pull request May 21, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anakin87 anakin87 anakin87 approved these changes
@Amnah199 Amnah199 Awaiting requested review from Amnah199 Amnah199 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees

No one assigned

Labels

topic:retriever topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate QueryExpander, MultiQueryTextRetriever and MultiQueryEmbeddingRetriever from haystack-experimental to haystack

3 participants

@davidsbatista @coveralls @anakin87