Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Collaborator
Pull Request Test Coverage Report for Build 20373119300Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
X|Y and X|None typing syntaxes
X|Y and X|None typing syntaxesX|Y and X|None)
anakin87
commented
Dec 17, 2025
anakin87
commented
Dec 17, 2025
anakin87
commented
Dec 17, 2025
anakin87
commented
Dec 17, 2025
anakin87
commented
Dec 17, 2025
anakin87
commented
Dec 17, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
reviewed
Dec 19, 2025
sjrl
approved these changes
Dec 19, 2025
Contributor
sjrl
left a comment
There was a problem hiding this comment.
Looks good! Let's make sure to give platform plenty of heads up about this change as well. Unsure if it effects the visual builder in any way.
mpangrazzi
approved these changes
Dec 19, 2025
This was referenced Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
We want to use
X | Yinstead ofUnion[X, Y]andX | Noneinstead ofOptional[X]across the codebase.Since the old syntax is still valid, we also want to ensure it continues to work correctly.
Proposed Changes:
Most relevant files
Since this PR is quite large, I'm reporting here the list of files with the most relevant changes. Most of the other changes have been automatically applied using Ruff.
pyproject.toml
haystack/utils/type_serialization.py
haystack/core/type_utils.py
haystack/core/super_component/utils.py
haystack/components/agents/state/state_utils.py
haystack/tools/parameters_schema_utils.py
test/core/pipeline/test_type_syntax_compatibility.py (new)
test/utils/test_type_serialization.py
test/core/test_type_utils.py
test/core/super_component/test_utils.py
test/components/agents/test_state_class.py
test/tools/test_parameters_schema_utils.py
test/components/routers/test_conditional_router.py
How did you test it?
Notes for the reviewer
In case this PR introduces bugs that we are not able to spot immediately, I hope that testing the future Release Candidate on Platform can help surface them.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.