docs: fix workflow for docs synchronization with search pipelinee - #10297
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anakin87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Docs-search-sync workflow has been failing for the last few days: https://github.com/deepset-ai/haystack/actions/runs/20702511584/job/59426976116
This workflow builds the docs in CI and uploads them to the search pipeline. Previously, the build worked correctly both in CI and on Vercel.
Now it's broken on the CI only. This likely happens due to new versions of packages but since build is partly cached on Vercel, this will likely also happen there in the future.
Proposed Changes:
useBaseUrlutility function: this should ensure images are resolved correctly both in Server Side Rendering and in browser(spent a lot of time figuring out how to solve 😅)
How did you test it?
Temporarily triggered build/sync in this PR: https://github.com/deepset-ai/haystack/actions/runs/20715279643/job/59465006138?pr=10297
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.