ci: auto-approve and merge API reference sync PRs#10853
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
julian-risch
requested changes
Mar 17, 2026
Member
julian-risch
left a comment
There was a problem hiding this comment.
Only one suggested change for a comment. Other than that the PR looks good to me!
| jobs: | ||
| auto-approve-and-merge: | ||
| if: | | ||
| github.event.pull_request.user.login == 'HaystackBot' && |
Member
There was a problem hiding this comment.
Looks good. HaystackBot is important here to prevent malicious users from creating PRs that get auto-merged.
Member
There was a problem hiding this comment.
github.event.pull_request.head.repo.full_name == github.repository could be added to prevent forks from triggering this job but HaystackBot doesn't use forks anyway.
No change request.
Member
Author
There was a problem hiding this comment.
added it to be extra-safe
Member
Author
|
Works: #10854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
--autoto merge PRs: they will be merged only after the required checks (from Branch Protection Rules) finish running. It's worth noting that Vercel deployments are not included in Branch Protection Rules, so we won't wait for them. To prevent broken builds (that, however, would not break the website), I already added a workflow to check API reference <-> Docusaurus compliance in ci: add workflow to check correct API reference generation #10843.How did you test it?
I haven't found a good way to test it before merging.
Worst-case scenario: it won't approve and merge PRs. So it should be safe to merge.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.