Skip to content

chore: fix CODEOWNERS to not assign reviewers to API ref updates#10870

Merged
anakin87 merged 1 commit intomainfrom
fix-codeowners
Mar 18, 2026
Merged

chore: fix CODEOWNERS to not assign reviewers to API ref updates#10870
anakin87 merged 1 commit intomainfrom
fix-codeowners

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Mar 18, 2026

Related Issues

The change did not work in #10869 (I was requested a review) since the last line in CODEOWNERS

*.md @deepset-ai/documentation @deepset-ai/open-source-engineering

asked for a review to @deepset-ai/documentation and @deepset-ai/open-source-engineering

(last line wins)

Proposed Changes:

  • change the order of rules to make them work (matches the syntax in GitHub docs)

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Mar 18, 2026 3:19pm

Request Review

@anakin87 anakin87 marked this pull request as ready for review March 18, 2026 15:19
@anakin87 anakin87 requested a review from a team as a code owner March 18, 2026 15:19
@anakin87 anakin87 requested review from sjrl and removed request for a team March 18, 2026 15:19
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@anakin87 anakin87 merged commit 632748a into main Mar 18, 2026
20 checks passed
@anakin87 anakin87 deleted the fix-codeowners branch March 18, 2026 15:35
@anakin87
Copy link
Copy Markdown
Member Author

It works finally! #10871

@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Mar 18, 2026

It works finally! #10871

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants