Skip to content

fix: pass documents as keyword argument in EmbeddingBasedDocumentSplitter #11022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Amnah199 wants to merge 1 commit into from
+2 −2
Closed

fix: pass documents as keyword argument in EmbeddingBasedDocumentSplitter #11022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions haystack/components/preprocessors/embedding_based_document_splitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def _calculate_embeddings(self, sentence_groups: list[str]) -> list[list[float]]
"""
# Create Document objects for each group
group_docs = [Document(content=group) for group in sentence_groups]
result = self.document_embedder.run(group_docs)
result = self.document_embedder.run(documents=group_docs)
embedded_docs = result["documents"]
return [doc.embedding for doc in embedded_docs]

Expand All @@ -320,7 +320,7 @@ async def _calculate_embeddings_async(self, sentence_groups: list[str]) -> list[
"""
# Create Document objects for each group
group_docs = [Document(content=group) for group in sentence_groups]
result = await self.document_embedder.run_async(group_docs) # type: ignore[attr-defined]
result = await self.document_embedder.run_async(documents=group_docs) # type: ignore[attr-defined]
embedded_docs = result["documents"]
return [doc.embedding for doc in embedded_docs]

Expand Down
Loading