Skip to content

chore: Revert addition of MultiFilterRetriever#11120

Merged
bogdankostic merged 1 commit intomainfrom
revert-multifilterretriever
Apr 16, 2026
Merged

chore: Revert addition of MultiFilterRetriever#11120
bogdankostic merged 1 commit intomainfrom
revert-multifilterretriever

Conversation

@bogdankostic
Copy link
Copy Markdown
Contributor

Proposed Changes:

This PR reverts the addition of the MultiFilterRetriever introduced in #11028. The component is redundant, given that the same can be achieved by embedding the list of filters in an OR filter clause and using the already existing FilterRetriever.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@bogdankostic bogdankostic requested a review from a team as a code owner April 16, 2026 11:34
@bogdankostic bogdankostic requested review from anakin87 and removed request for a team April 16, 2026 11:34
@bogdankostic bogdankostic added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 16, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Apr 16, 2026 11:34am

Request Review

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Apr 16, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 24507949236

Coverage decreased (-0.01%) to 92.844%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
core/pipeline/async_pipeline.py 2 70.76%

Coverage Stats

Coverage Status
Relevant Lines: 17175
Covered Lines: 15946
Line Coverage: 92.84%
Coverage Strength: 0.93 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

🧹

@bogdankostic bogdankostic merged commit 264e7d1 into main Apr 16, 2026
32 checks passed
@bogdankostic bogdankostic deleted the revert-multifilterretriever branch April 16, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants