fix: require messages input parameter in Agent component#11147
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Coverage Report for CI Build 24655141668Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Warning No base build found for commit Coverage: 92.855%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
julian-risch
left a comment
There was a problem hiding this comment.
Code changes look good to me! I suggest we extend the release note with an upgrade section that tells users to add messages=[] if they didn't have messages for the Agent at all in Haystack 2.27 or Haystack 2.26. We can mention that only users of these two versions are affected.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| fixes: | |||
There was a problem hiding this comment.
I suggest we also include a note in the section upgrade given that this is a breaking change for users you started to use Agent without messages in the mean time. I don't expect many users to be affected if any at all.
Related Issues
pipeline_run_argsinjection #11109Proposed Changes:
Make the
messagesparam of Agent required.Same issue as outlined here #10734
How did you test it?
Updated unit tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.