Skip to content

chore: remove check for author association in code review workflow#11168

Merged
julian-risch merged 1 commit intomainfrom
code-review-fix
Apr 22, 2026
Merged

chore: remove check for author association in code review workflow#11168
julian-risch merged 1 commit intomainfrom
code-review-fix

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Apr 21, 2026

Related Issues

Claude code reviews don't get consistently triggered for team members' PRs.
If you want to get a Claude Code review of a team member's PR in Haystack, it seems to work right now only if you first open a draft PR and then mark it as ready for review. I described why I believe that in more detail internally here. That seems to be the reason why Stefano's PR triggered the workflow and Sebastian's PR didn't.

Logs of a workflow run show that Sebastian's role was wrongly resolved to CONTRIBUTOR instead of MEMBER via GitHub's web hook.

Proposed Changes:

  • The author_association check is removed. The remaining guards are:

!github.event.pull_request.head.repo.fork: blocks PRs from forks (external contributors on the pull_request path)
The action's own permission check: validates write access at runtime using the OIDC token (as seen in the logs: Permission level retrieved: write / Actor has write access: write)
pull_request_target + claude-review label: still the manual path for external contributor PRs

This means all deepset org members lwill now get reviewed regardless of what author_association GitHub puts in the webhook payload.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Apr 21, 2026 4:14pm

Request Review

@julian-risch julian-risch marked this pull request as ready for review April 21, 2026 16:19
@julian-risch julian-risch requested a review from a team as a code owner April 21, 2026 16:19
@julian-risch julian-risch requested review from davidsbatista and removed request for a team April 21, 2026 16:19
@julian-risch julian-risch merged commit 2487503 into main Apr 22, 2026
22 of 24 checks passed
@julian-risch julian-risch deleted the code-review-fix branch April 22, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants