chore: remove check for author association in code review workflow#11168
Merged
julian-risch merged 1 commit intomainfrom Apr 22, 2026
Merged
chore: remove check for author association in code review workflow#11168julian-risch merged 1 commit intomainfrom
julian-risch merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
davidsbatista
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Claude code reviews don't get consistently triggered for team members' PRs.
If you want to get a Claude Code review of a team member's PR in Haystack, it seems to work right now only if you first open a draft PR and then mark it as ready for review. I described why I believe that in more detail internally here. That seems to be the reason why Stefano's PR triggered the workflow and Sebastian's PR didn't.
Logs of a workflow run show that Sebastian's role was wrongly resolved to CONTRIBUTOR instead of MEMBER via GitHub's web hook.
Proposed Changes:
!github.event.pull_request.head.repo.fork: blocks PRs from forks (external contributors on the pull_request path)
The action's own permission check: validates write access at runtime using the OIDC token (as seen in the logs: Permission level retrieved: write / Actor has write access: write)
pull_request_target + claude-review label: still the manual path for external contributor PRs
This means all deepset org members lwill now get reviewed regardless of what author_association GitHub puts in the webhook payload.
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.