Skip to content

refactor!: Remove agent breakpoint and agent snapshot#11202

Merged
sjrl merged 11 commits into
v3from
refactor-agent-tool-invoker
May 19, 2026
Merged

refactor!: Remove agent breakpoint and agent snapshot#11202
sjrl merged 11 commits into
v3from
refactor-agent-tool-invoker

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Apr 27, 2026

Related Issues

Proposed Changes:

Remove break point and snapshot support from the internals of Agent. Motivation is that it's not heavily used and adds a lot of complexity to the Agent internals.

Open to adding this back in the future if we see a strong need (e.g. HITL + Breakpoints to enable long running Agents). And if we decide to do so I think there is a simpler way to re-add it than in it's current form.

Updated MIGRATION.md and added an upgrade release note describing the breaking changes.

How did you test it?

Updated existing tests.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview May 19, 2026 11:25am

Request Review

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/agents
  agent.py 829, 835-851
  haystack/core
  errors.py 127, 142-144, 151-153
  haystack/core/pipeline
  breakpoint.py 53, 94-97, 188
  pipeline.py 340, 356-357
  haystack/dataclasses
  __init__.py
  breakpoints.py
  haystack/human_in_the_loop
  strategies.py 471
Project Total  

This report was generated by python-coverage-comment-action

@sjrl sjrl changed the base branch from main to v3 May 18, 2026 08:41
@sjrl sjrl self-assigned this May 19, 2026
@sjrl sjrl marked this pull request as ready for review May 19, 2026 08:14
@sjrl sjrl requested review from a team as code owners May 19, 2026 08:14
@sjrl sjrl requested review from anakin87 and removed request for a team May 19, 2026 08:14
@claude
Copy link
Copy Markdown

claude Bot commented May 19, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copy link
Copy Markdown
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy about the simplification!

I left a minor comment.

In addition, we should track documentation changes to be done. But maybe MIGRATION.md is sufficient. WDYT?

Please wait before merging: I want to understand if 3.0.0-rc0 version and tag are needed before...

Comment thread MIGRATION.md
@sjrl
Copy link
Copy Markdown
Contributor Author

sjrl commented May 19, 2026

But maybe MIGRATION.md is sufficient. WDYT?

Good point. I think MIGRATION.md is sufficient for now and we can update the docs later after we're done merging our changes and before the v3 release. WDYT?

Copy link
Copy Markdown
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've applied the minor change I requested, feel free to merge: version tag has already been placed.

@sjrl sjrl enabled auto-merge (squash) May 19, 2026 11:26
@sjrl sjrl merged commit f4b76a1 into v3 May 19, 2026
26 checks passed
@sjrl sjrl deleted the refactor-agent-tool-invoker branch May 19, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants