refactor: Refactor internals of AsyncPipeline#11431
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
sjrl
added
the
ignore-for-release-notes
sjrl
changed the title
AsyncPipelineAsyncPipeline
julian-risch
approved these changes
May 29, 2026
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me! Nothing against this refactoring from my side. Test coverage isn't great so that's something we could improve in future. Particularly, _run_component_in_isolation (previously _run_highest_in_isolation) would be worth testing in my opinion.
| if partial_result: | ||
| yield {finished_component_name: _deepcopy_with_exceptions(partial_result)} | ||
|
|
||
| async def _run_component_in_isolation( |
Member
There was a problem hiding this comment.
Now that this is an instance method, we could extend unit test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Existing tests.
Notes for the reviewer
With this refactor I think we could more easily add parallel execution support to Pipeline.run using a thread pool executor by following the same scheduling logic as AsyncPipeline except replace asyncio calls with thread pool executor calls.
I think doing this for v3 could be a good time since we will have time to let the run logic be tested as we develop to potentially catch any issues.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.